fix metric checking tests #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test did not actually look for only listed methods. additionally, adds a small time buffer to alow metrics to finish being created.
galxy25
reviewed
Feb 29, 2024
main_test.go
Outdated
| @@ -88,7 +88,8 @@ var ( | |||
| // search for any request metrics between startTime and time.Now() for particular request methods | |||
| // if testedmethods is empty, all metrics in timeframe are returned. | |||
| func findMetricsInWindowForMethods(db database.PostgresClient, startTime time.Time, testedmethods []string) []database.ProxiedRequestMetric { | |||
| endTime := time.Now() | |||
| // add small buffer into future in case metrics are still being created | |||
| endTime := time.Now().Add(100 * time.Millisecond) | |||
There was a problem hiding this comment.
could source from an environment variable and set to higher values in ci if tests are being flaky
galxy25
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test did not actually look for only listed methods. additionally, adds a small time buffer to alow metrics to finish being created.